b4n left a comment (geany/geany#4472)

> I think to remember it was necessary but this should be verified again to get 
> sure. It could also be that there was another problem which I didn't see or 
> there is a better fix than this.

OK, for the moment I added a commit that runs the necessary command for both 
themes.  The only real downside is that it can't use the built-in 
`gnome.post_install()`, but it's easy enough to do manually.  Second downside 
is that I had to create a fallback for meson < 0.57 not to run this in the 
DESTDIR, but that could be dropped if we stop supporting Meson on Bullseye (it 
seems to virtually be the only distro that has >= 0.56 we depend on, but not 
0.57).

> To be honest, I didn't even look into the failing cross build runs when I see 
> your great attempt here and I hope we can simply drop the cross build 
> workflow.

Fair enough :)  To be a tad more sure I added the test installer/test 
geany/test uninstaller steps to the native builds to see if they work there -- 
and I guess that could be useful as well?  Anyway, we'll see for this, but if 
it succeeds the consensus will be to drop the cross ones :)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4472#issuecomment-3606811015
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4472/[email protected]>

Reply via email to