b4n left a comment (geany/geany#4433)

GTK4 dropped <kbd>Primary</kbd> AFAIK (see e.g. 
https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkaccelgroup.c?ref_type=heads#L580).

If we really want to drop <kbd>Primary</kbd> (which is supposed to adapt to the 
platform's, well, primary accelerator), we could post-process the string -- 
e.g. replace `<Primary>` with whatever is the actual primary modifier.
However, this is not trivial (look at the GTK code generating it) if we don't 
want to blindly assume <kbd>Primary</kbd> == <kbd>Control</kbd> but rather undo 
the mapping (this requires figuring out what is actually the modifier with 
"primary intent", and then use the representation for this as replacement).

I myself don't mind enough to go to such trouble, especially as as @eht16 said 
it's not specific to Geany. So a better solution for somebody that care enough 
might be to actually patch GTK3 not to display those accelerators (but still 
parse them, as it would break compatibility otherwise), and that's likely 
removing a few lines in the mentioned function. Easy to do for oneself, but 
unlikely to be accepted upstream I don't think.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/4433#issuecomment-3614427286
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/4433/[email protected]>

Reply via email to