@eht16 commented on this pull request.
> {
- /* TODO use the code below post-1.28 as it introduces a
new string
- g_set_error(error, gerror->domain, gerror->code,
- _("Failed to convert working directory into
locale encoding: %s"), gerror->message);
- */
- g_propagate_error(error, gerror);
- success = FALSE;
+ w_working_directory =
g_utf8_to_utf16(utf8_working_directory, -1, NULL, NULL, &gerror);
+ if (! w_working_directory)
+ {
+ /* TODO use the code below post-1.28 as it
introduces a new string
+ g_set_error(error, gerror->domain, gerror->code,
Since we are somewhat post 1.28 already :D, maybe we could remove the `TODO`
and set a specific error message?
I know this is not the subject of this PR but while being at it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4482#pullrequestreview-3553920457
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4482/review/[email protected]>
