@eht16 commented on this pull request.


>               {
-                       /* TODO use the code below post-1.28 as it introduces a 
new string
-                       g_set_error(error, gerror->domain, gerror->code,
-                               _("Failed to convert command into locale 
encoding: %s"), gerror->message);
-                       */
-                       g_propagate_error(error, gerror);
-                       success = FALSE;
+                       w_command = g_utf8_to_utf16(utf8_cmd, -1, NULL, NULL, 
&gerror);
+                       if (! w_command)
+                       {
+                               /* TODO use the code below post-1.28 as it 
introduces a new string

Same, we are past 1.28 :).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4482#pullrequestreview-3553923189
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4482/review/[email protected]>

Reply via email to