@WrapEarnPass commented on this pull request.
> @@ -45,6 +45,19 @@
GeanyPlugin *geany_plugin;
GeanyData *geany_data;
+
+/* Callback function for document activate */
+static void plugin_workbench_on_doc_activate(G_GNUC_UNUSED GObject * obj,
GeanyDocument * doc,
+
G_GNUC_UNUSED gpointer user_data)
+{
+ /* it seems odd to assert this here,
+ * as an untitled doc (new one) would have no filename.
+ */
+ g_return_if_fail(doc != NULL && doc->file_name != NULL);
It seems confusing because I am confused. I copied this guard to honor the
pattern established by the project maintainer. Until I get clarification, I am
afraid to remove it, as I have already had to close one pull due to changing
something that actually turned out to be load-bearing elsewhere.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1576#discussion_r3447412433
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1576/review/[email protected]>
