[GitHub] [arrow] fsaintjacques commented on a change in pull request #7000: ARROW-8065: [C++][Dataset] Refactor ScanOptions and Fragment relation

[GitBox]

fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413045582



##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -222,9 +214,8 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
 }
 
 Result<std::shared_ptr<FileSystemDataset>> FileSystemDataset::Write(
-    const WritePlan& plan, std::shared_ptr<ScanContext> scan_context) {
-  std::vector<std::shared_ptr<ScanOptions>> options(plan.paths.size());
-
+    const WritePlan& plan, std::shared_ptr<ScanOptions> scan_options,

Review comment:
       That's a task for 
[ARROW-8382](https://jira.apache.org/jira/projects/ARROW/issues/ARROW-8382). 
The writer shouldn't be aware of such issue, it takes a file source, a format, 
a RecordBatchReader (the dropping should happen internally here) and writes it­.
   
   Since the Writer API has no bindings and not in use yet, I added this to 
ARROW-8382 so we can prioritise  ARROW-8062 (parquet dataset) and ARROW-8318 
(fragment stored in dataset).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org