jorisvandenbossche commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413622598
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -402,23 +401,21 @@ Result<ScanTaskIterator> ParquetFileFormat::ScanFile(
}
Result<std::shared_ptr<FileFragment>> ParquetFileFormat::MakeFragment(
- FileSource source, std::shared_ptr<ScanOptions> options,
- std::shared_ptr<Expression> partition_expression, std::vector<int>
row_groups) {
+ FileSource source, std::shared_ptr<Expression> partition_expression,
+ std::vector<int> row_groups) {
return std::shared_ptr<FileFragment>(
- new ParquetFileFragment(std::move(source), shared_from_this(),
std::move(options),
+ new ParquetFileFragment(std::move(source), shared_from_this(),
std::move(partition_expression),
std::move(row_groups)));
}
Result<std::shared_ptr<FileFragment>> ParquetFileFormat::MakeFragment(
- FileSource source, std::shared_ptr<ScanOptions> options,
- std::shared_ptr<Expression> partition_expression) {
- return std::shared_ptr<FileFragment>(
- new ParquetFileFragment(std::move(source), shared_from_this(),
std::move(options),
- std::move(partition_expression), {}));
+ FileSource source, std::shared_ptr<Expression> partition_expression) {
+ return std::shared_ptr<FileFragment>(new ParquetFileFragment(
+ std::move(source), shared_from_this(), std::move(partition_expression),
{}));
}
Result<FragmentIterator> ParquetFileFormat::GetRowGroupFragments(
- const ParquetFileFragment& fragment, std::shared_ptr<Expression>
extra_filter) {
+ const ParquetFileFragment& fragment, std::shared_ptr<Expression> filter) {
Review comment:
Small comment: in the header file it is still called "extra_filter"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
