andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413407658
##########
File path: rust/arrow/src/array/equal.rs
##########
@@ -692,6 +692,22 @@ impl ArrayEqual for StructArray {
}
}
+impl ArrayEqual for UnionArray {
+ fn equals(&self, _other: &dyn Array) -> bool {
+ unimplemented!()
+ }
+
+ fn range_equals(
+ &self,
+ _other: &dyn Array,
+ _start_idx: usize,
+ _end_idx: usize,
+ _other_start_idx: usize,
+ ) -> bool {
+ unimplemented!()
Review comment:
Is this intentionally unimplemented? If so, would be good to add a
comment explaining that.
##########
File path: rust/arrow/src/array/equal.rs
##########
@@ -1046,6 +1062,30 @@ impl PartialEq<FixedSizeBinaryArray> for Value {
}
}
+impl JsonEqual for UnionArray {
+ fn equals_json(&self, _json: &[&Value]) -> bool {
+ unimplemented!()
Review comment:
Is this intentionally unimplemented? If so, would be good to add a
comment explaining that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
