paddyhoran commented on pull request #7004: URL: https://github.com/apache/arrow/pull/7004#issuecomment-618761556
@andygrove just going to leave a general comment as it's all related. Overall, I felt this PR was getting big, I was trying to avoid getting into the IPC stuff in this PR, this is the reason I left some things `unimplemented`. I created the following follow up JIRA's to address all these issues. Both `JsonEquals` (ARROW-8547) and `ArrayEquals` (ARROW-8576) were introduced to compare arrays as part of the IPC implementation but are required to be implemented to implement the `Array` trait. Adding `UnionArray` to `get_fb_field_type` is obviously IPC related as well (ARROW-8546). I waited until the recent release was cut before submitting this so as to make sure that the `unimplemented` didn't get released. I'll follow up on the items above once I get this much merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
