fsaintjacques commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r413811549
##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -260,12 +260,28 @@ class FileReaderImpl : public FileReader {
Status GetRecordBatchReader(const std::vector<int>& row_group_indices,
const std::vector<int>& column_indices,
- std::unique_ptr<RecordBatchReader>* out)
override;
+ std::unique_ptr<RecordBatchReader>* out,
Review comment:
The FileReader object already has an `ArrowReaderProperties` property
with this configuration. There is no need to add this extra parameter. Instead,
you should add a setter method `set_batch_size()` analogous to
`set_use_threads()` (in reader.h).
This comment applies to every GetRecordBatchReader methods you added the
parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
