fsaintjacques commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r416018166



##########
File path: python/pyarrow/_parquet.pyx
##########
@@ -1083,6 +1084,50 @@ cdef class ParquetReader:
     def set_use_threads(self, bint use_threads):
         self.reader.get().set_use_threads(use_threads)
 
+    def iter_batches(self, int64_t batch_size, row_groups, column_indices=None,

Review comment:
       Noted for consistency. I find it un-intuitive that calling this method 
changes the batch size (or threading) for the following callers. Since this is 
not introduced by this PR, I won't make this a blocking issue.
   
   I'll leave @jorisvandenbossche decide if we should have a followup to fix 
this anti-pattern.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to