rymurr commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r420597489
##########
File path:
java/vector/src/test/java/org/apache/arrow/vector/ITTestLargeVector.java
##########
@@ -131,16 +139,17 @@ private static void testLargeDecimalVector() {
assertEquals(0, buf.getLong(8));
if ((i + 1) % 10000 == 0) {
- System.out.println("Successfully read " + (i + 1) + " values");
+ logger.debug("Successfully read {} values", i + 1);
}
}
- System.out.println("Successfully read " + vecLength + " values");
+ logger.info("Successfully read {} values", vecLength);
}
- System.out.println("Successfully released the large vector.");
+ logger.info("Successfully released the large vector.");
}
- private static void testLargeFixedSizeBinaryVector() {
- System.out.println("Testing large fixed size binary vector.");
+ @Test
+ public void testLargeFixedSizeBinaryVector() {
+ logger.info("Testing large fixed size binary vector.");
Review comment:
Not sure I understand the question. I will answer what I think but
please let me know if I am misunderstanding . these tests are run as part of
the failsafe plugin (by way of the IT prefix on the class name) as such they
are only run when the `integration-test` profile is active.
I see the `arrow.vector.max_allocation_bytes` is set to `Long.MAX_VALUE` by
default and the original test didn't have any docs/settings for changing that
default. If it is supposed to be set to a specific value for the test we can
specify in failsafe args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
