liyafan82 commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r420725486
##########
File path:
java/vector/src/test/java/org/apache/arrow/vector/ITTestLargeVector.java
##########
@@ -131,16 +139,17 @@ private static void testLargeDecimalVector() {
assertEquals(0, buf.getLong(8));
if ((i + 1) % 10000 == 0) {
- System.out.println("Successfully read " + (i + 1) + " values");
+ logger.debug("Successfully read {} values", i + 1);
}
}
- System.out.println("Successfully read " + vecLength + " values");
+ logger.info("Successfully read {} values", vecLength);
}
- System.out.println("Successfully released the large vector.");
+ logger.info("Successfully released the large vector.");
}
- private static void testLargeFixedSizeBinaryVector() {
- System.out.println("Testing large fixed size binary vector.");
+ @Test
+ public void testLargeFixedSizeBinaryVector() {
+ logger.info("Testing large fixed size binary vector.");
Review comment:
Thanks a lot for your clarification. You mean the class name has a
prefix "IT", so it will not be run as an ordinary unit test, but will be run as
an integration test? If so, it is cool!
BTW, the default value of `arrow.vector.max_allocation_bytes` should be 1MB
by default (pls see
https://github.com/apache/arrow/blob/master/java/pom.xml#406), so if the
allocation size exceeds this limit, an exception will be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
