[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

[GitBox]

emkornfield commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-628364641


   OK it seems like clang and GCC perform very differently.
   
   Clang-8 new code vs master:
   
![image](https://user-images.githubusercontent.com/17869838/81888336-ff86bb00-9555-11ea-97da-8becce12bee2.png)
   
   GCC 7.5 (inline with the results from @pitrou):
   
![image](https://user-images.githubusercontent.com/17869838/81888475-3fe63900-9556-11ea-98d6-a1dff1ea24e2.png)
   
   Interesting it looks like GCC 7.5 does better on the write path (GCC vs 
Clang on master):
   
![image](https://user-images.githubusercontent.com/17869838/81888643-a53a2a00-9556-11ea-821f-8439043da4c8.png)
   
   
   
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org