emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-629737181
@pitrou https://github.com/apache/arrow/pull/6985/commits/a36dc55efe3def27eef413b8e17567ec400a01ff adds a benchmark. Should be cherry-pickable to a clean branch for comparison. On my machine it shows ~2X speedup. ``` Before: --------------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... --------------------------------------------------------------------------------------------------------- BM_DefinitionLevelsToBitmapRepeatedAllMissing 2314 ns 2314 ns 302395 bytes_per_second=844.019M/s BM_DefinitionLevelsToBitmapRepeatedAllPresent 2333 ns 2333 ns 301106 bytes_per_second=837.088M/s BM_DefinitionLevelsToBitmapRepeatedMostPresent 2458 ns 2458 ns 286182 bytes_per_second=794.611M/s ``` ``` After: --------------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... --------------------------------------------------------------------------------------------------------- BM_DefinitionLevelsToBitmapRepeatedAllMissing 1054 ns 1054 ns 665201 bytes_per_second=1.80969G/s BM_DefinitionLevelsToBitmapRepeatedAllPresent 1218 ns 1218 ns 577196 bytes_per_second=1.56564G/s BM_DefinitionLevelsToBitmapRepeatedMostPresent 1288 ns 1288 ns 542522 bytes_per_second=1.48129G/s ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
