jorisvandenbossche commented on a change in pull request #7223:
URL: https://github.com/apache/arrow/pull/7223#discussion_r428043526
##########
File path: python/pyarrow/_csv.pyx
##########
@@ -296,10 +297,31 @@ cdef class ParseOptions:
out.options = options
return out
- def __reduce__(self):
- return ParseOptions, (self.delimiter, self.quote_char,
- self.double_quote, self.escape_char,
- self.newlines_in_values, self.ignore_empty_lines)
+ def __getstate__(self):
+ return (self.delimiter, self.quote_char, self.double_quote,
+ self.escape_char, self.newlines_in_values,
+ self.ignore_empty_lines)
+
+ def __setstate__(self, state):
+ (self.delimiter, self.quote_char, self.double_quote,
+ self.escape_char, self.newlines_in_values,
+ self.ignore_empty_lines) = state
+
+
+cdef class _ISO8601:
+ """
+ A special object indicating ISO-8601 parsing.
Review comment:
Alternative could also be to use a string for this? (so you could do
like `["ISO-8601", "%Y/%m/%d"]`)
I understand that it is cleaner to use a separate object since "ISO-8601" is
strictly speaking not a format string, but it would that users need to use yet
another object (no strong objection to the current approach, though, to be
clear).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
