fsaintjacques commented on a change in pull request #7223:
URL: https://github.com/apache/arrow/pull/7223#discussion_r434275053
##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -45,6 +45,10 @@ class ARROW_EXPORT TimestampParser {
virtual bool operator()(const char* s, size_t length, TimeUnit::type
out_unit,
int64_t* out) const = 0;
+ virtual const char* kind() const = 0;
+
+ virtual const char* detail() const;
Review comment:
Don't make this method part of the interface and only part of
StrptimeTimestampParser.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
