pitrou commented on a change in pull request #7357:
URL: https://github.com/apache/arrow/pull/7357#discussion_r438718060
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -48,6 +48,16 @@ struct AsciiUpper {
}
};
+struct AsciiLower {
+ template <typename... Ignored>
+ static std::string Call(KernelContext*, const util::string_view& val) {
+ std::string result = val.to_string();
Review comment:
I think we should start finding a sane strategy right now for the
existing `ascii_upper` kernel. Indeed, a different strategy will be needed for
utf8 `upper`.
In both cases, this probably means implementing those kernels as "vector"
kernels, not "scalar" kernels (because the latter implies you only process one
item at a time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
