maartenbreddels commented on a change in pull request #7357:
URL: https://github.com/apache/arrow/pull/7357#discussion_r438723590
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -48,6 +48,16 @@ struct AsciiUpper {
}
};
+struct AsciiLower {
+ template <typename... Ignored>
+ static std::string Call(KernelContext*, const util::string_view& val) {
+ std::string result = val.to_string();
Review comment:
Agree. Happy to take a look into turning this into a 'vector' kernel, if
you have some pointer that would be great. This also answers a question I had
if it would be possible to operate on a full array/chunk in the existing
framework, I guess that's a yes.
Any reason not to reuse the offset buffer, even if the offset is not 0?
What is the advantage of scalar kernels in Arrow? Apart from avoiding
boilerplate? Also wondering if this is related to the Gandiva connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
