nealrichardson commented on a change in pull request #7441:
URL: https://github.com/apache/arrow/pull/7441#discussion_r440976677
##########
File path: r/src/array_to_vector.cpp
##########
@@ -418,6 +418,7 @@ class Converter_Struct : public Converter {
std::vector<std::shared_ptr<Converter>> converters;
};
+// Shouldn't this cast before dividing? Otherwise we're doing integer division
Review comment:
I would think we'd be more interested in fidelity of the data
transformation than raw speed. Assuming I understand what the operators are
doing, isn't `float(1234 / 1000)` a lot different from `float(1234) / 1000`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
