fsaintjacques commented on a change in pull request #7441:
URL: https://github.com/apache/arrow/pull/7441#discussion_r441004282
##########
File path: r/src/array_to_vector.cpp
##########
@@ -418,6 +418,7 @@ class Converter_Struct : public Converter {
std::vector<std::shared_ptr<Converter>> converters;
};
+// Shouldn't this cast before dividing? Otherwise we're doing integer division
Review comment:
Correct, you lose the fractional part, but yes we can revise that. I
have no preference, it's probably better to preserve precision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
