projjal commented on a change in pull request #7504:
URL: https://github.com/apache/arrow/pull/7504#discussion_r443442994
##########
File path: cpp/src/gandiva/to_date_holder.cc
##########
@@ -83,7 +83,7 @@ int64_t ToDateHolder::operator()(ExecutionContext* context,
const std::string& d
// 1. processes date that do not match the format.
// 2. does not process time in format +08:00 (or) id.
int64_t seconds_since_epoch = 0;
- if (!::arrow::internal::ParseTimestampStrptime(
+ if (!::arrow::internal::ParseTimestampStrptimeFromCString(
data.c_str(), data.length(), pattern_.c_str(),
Review comment:
Makes sense. I will update the patch to pass the data buffer directly to
the orginal parsetimestamp method. The new method won't be necessary then i
guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
