[GitHub] [arrow] pitrou commented on pull request #7504: ARROW-9193: [C++] Avoid spurious intermediate string copy in ToDateHolder

Mon, 22 Jun 2020 07:12:04 -0700 


pitrou commented on pull request #7504:
URL: https://github.com/apache/arrow/pull/7504#issuecomment-647544705


   @projjal Can you fix the Windows build failures (see AppVeyor build):
   ```
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(55): error C2220: 
warning treated as error - no 'object' file generated
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(55): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(60): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(65): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(79): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(84): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(96): warning C4267: 
'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(101): warning 
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(106): warning 
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(111): warning 
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(117): warning 
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
   C:/projects/arrow/cpp/src/gandiva/to_date_holder_test.cc(131): warning 
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
   ```
   ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to