wesm commented on pull request #7521: URL: https://github.com/apache/arrow/pull/7521#issuecomment-647888437
FWIW the performance issue seems to be more pronounced on gcc than clang, here is the benchmark comparison on my machine with clang-8 ``` benchmark baseline contender change % counters 1 SortToIndicesInt64Count/32768/10000/min_time:1.000 1.560 GiB/sec 2.000 GiB/sec 28.163 {'iterations': 70030, 'null_percent': 0.01} 15 SortToIndicesInt64Compare/32768/10000/min_time:1.000 145.735 MiB/sec 158.918 MiB/sec 9.046 {'iterations': 6654, 'null_percent': 0.01} 5 SortToIndicesInt64Compare/32768/100/min_time:1.000 149.117 MiB/sec 159.609 MiB/sec 7.036 {'iterations': 6545, 'null_percent': 1.0} 7 SortToIndicesInt64Compare/32768/0/min_time:1.000 153.027 MiB/sec 162.227 MiB/sec 6.012 {'iterations': 6862, 'null_percent': 0.0} 4 SortToIndicesInt64Compare/32768/10/min_time:1.000 160.419 MiB/sec 167.725 MiB/sec 4.554 {'iterations': 6934, 'null_percent': 10.0} 2 SortToIndicesInt64Compare/32768/2/min_time:1.000 255.024 MiB/sec 260.284 MiB/sec 2.063 {'iterations': 11390, 'null_percent': 50.0} 9 SortToIndicesInt64Count/32768/100/min_time:1.000 1.486 GiB/sec 1.458 GiB/sec -1.912 {'iterations': 66757, 'null_percent': 1.0} 10 SortToIndicesInt64Count/32768/0/min_time:1.000 2.143 GiB/sec 2.067 GiB/sec -3.568 {'iterations': 98191, 'null_percent': 0.0} 13 SortToIndicesInt64Count/8388608/1/min_time:1.000 4.215 GiB/sec 3.813 GiB/sec -9.531 {'iterations': 762, 'null_percent': 100.0} 11 SortToIndicesInt64Count/32768/2/min_time:1.000 679.023 MiB/sec 609.379 MiB/sec -10.256 {'iterations': 29602, 'null_percent': 50.0} 0 SortToIndicesInt64Count/1048576/1/min_time:1.000 4.487 GiB/sec 4.021 GiB/sec -10.400 {'iterations': 6550, 'null_percent': 100.0} 12 SortToIndicesInt64Compare/8388608/1/min_time:1.000 4.250 GiB/sec 3.762 GiB/sec -11.476 {'iterations': 766, 'null_percent': 100.0} 6 SortToIndicesInt64Count/32768/1/min_time:1.000 4.758 GiB/sec 4.185 GiB/sec -12.040 {'iterations': 217705, 'null_percent': 100.0} 8 SortToIndicesInt64Compare/32768/1/min_time:1.000 4.730 GiB/sec 4.125 GiB/sec -12.780 {'iterations': 213908, 'null_percent': 100.0} 3 SortToIndicesInt64Compare/1048576/1/min_time:1.000 4.556 GiB/sec 3.953 GiB/sec -13.228 {'iterations': 6539, 'null_percent': 100.0} 14 SortToIndicesInt64Count/32768/10/min_time:1.000 1.316 GiB/sec 1.051 GiB/sec -20.108 {'iterations': 59539, 'null_percent': 10.0} ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org