cyb70289 edited a comment on pull request #7521: URL: https://github.com/apache/arrow/pull/7521#issuecomment-647914768
> I'm refactoring to nix util::optional. I'm too tired to finish it tonight so I'll work on it tomorrow morning. If the perf regression isn't gone I'll rewrite the sort kernels. ~~Very likely I'm wrong. I remember util::optional is added due to CI failure https://github.com/apache/arrow/pull/6495#issuecomment-593732821~~ I think this patch is okay. Sorting regression can be fixed (maybe improved). I'm okay to do the follow up changes. I refined util::optional (not sure if same as @wesm thought). No performance difference from this change, still much lower than original code. Diff attached at https://pastebin.com/ywbPxyLL, hope it can save some time for @wesm :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
