emkornfield commented on a change in pull request #7604:
URL: https://github.com/apache/arrow/pull/7604#discussion_r449119094
##########
File path: python/pyarrow/tests/test_pandas.py
##########
@@ -3321,9 +3321,12 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
-def test_struct_with_timestamp_tz():
+def test_nested_with_timestamp_tz():
# ARROW-7723
ts = pd.Timestamp.now()
+ # This is used for verifying timezone conversion to micros are not
+ # important
+ ts_dt = ts.to_pydatetime().replace(microsecond=0)
Review comment:
> There is one failure (which involves datetimes with timezones, but
can't directly understand if it also involves structs):
>
> ```
> ======================================================================
> FAIL: test_grouped_over_window_with_key
(pyspark.sql.tests.test_pandas_grouped_map.GroupedMapInPandasTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/spark/python/pyspark/sql/tests/test_pandas_grouped_map.py", line
588, in test_grouped_over_window_with_key
> self.assertTrue(all([r[0] for r in result]))
> AssertionError: False is not true
>
> ----------------------------------------------------------------------
> Ran 21 tests in 141.194s
>
> FAILED (failures=1)
> ```
>
>
https://github.com/apache/spark/blob/7fda184f0fc39613fb68e912c189c54b93c638e6/python/pyspark/sql/tests/test_pandas_grouped_map.py#L546-L574
Yeah this seems strange. @BryanCutler do you have a sense of what is going
on here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
