wesm commented on a change in pull request #7598:
URL: https://github.com/apache/arrow/pull/7598#discussion_r449192771
##########
File path: cpp/src/arrow/array/array_nested.cc
##########
@@ -678,6 +680,10 @@ Result<std::shared_ptr<Array>> DenseUnionArray::Make(
return Status::TypeError("UnionArray type_ids must be signed int8");
}
+ if (type_ids.null_count() != 0) {
+ return Status::Invalid("Union type ids may not have nulls");
+ }
+
if (value_offsets.null_count() != 0) {
return Status::Invalid("Make does not allow NAs in value_offsets");
Review comment:
Yes, I'll search for usages of "NA" and replace with null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
