wesm commented on a change in pull request #7598:
URL: https://github.com/apache/arrow/pull/7598#discussion_r449194292
##########
File path: cpp/src/arrow/array/builder_nested.h
##########
@@ -395,8 +395,17 @@ class ARROW_EXPORT StructBuilder : public ArrayBuilder {
return Status::OK();
}
- Status AppendNull() final { return Append(false); }
+ /// \brief Append a null value. Automatically appends a null to each child
+ /// builder.
Review comment:
Ah good point, I didn't think about the triggering of creating a
validity bitmap.
AppendEmptyValue / AppendEmptyValues ("AppendZero" makes less sense for e.g.
BinaryBuilder) seems like as reasonable thing to add, I'll look into this. This
definitely increases the scope of the PR, though, do you think it would be
better to do this as a follow up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
