rok commented on a change in pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#discussion_r450344910
##########
File path: python/pyarrow/tensor.pxi
##########
@@ -199,7 +202,13 @@ shape: {0.shape}""".format(self)
for x in dim_names:
c_dim_names.push_back(tobytes(x))
- coords = np.vstack([obj.row, obj.col]).T
+ row = obj.row
+ col = obj.col
+ if obj.has_canonical_format:
+ order = np.lexsort((col, row)) # row-major order
Review comment:
The idea of canonical COO index IMO unnecessarily hides the two
properties (presence of duplication and row-ordered-ness).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
