rok commented on a change in pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#discussion_r452831292
##########
File path: python/pyarrow/tensor.pxi
##########
@@ -270,8 +279,10 @@ shape: {0.shape}""".format(self)
&out_data, &out_coords))
data = PyObject_to_object(out_data)
coords = PyObject_to_object(out_coords)
- result = coo_matrix((data[:, 0], (coords[:, 0], coords[:, 1])),
- shape=self.shape)
+ row, col = coords[:, 0], coords[:, 1]
+ result = coo_matrix((data[:, 0], (row, col)), shape=self.shape)
+ if self.has_canonical_format:
+ result.sum_duplicates()
Review comment:
Oh, we're checking if `SparseCOOTensor.has_canonical_format` not
`scipy.coo_matrix.has_canonical_format`. Got it.
What about if the it's not canonical? Then we return noncanonical scipy
object? Seems good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
