wesm commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-657159308
I simplified many of the templates to not require an Arrow type parameter
and do less inlining (which doesn't seem to make much of a difference
performance wise and it inflates binary sizes).
I made a couple other tweaks to the BinaryToBoolean helper, benchmarks are
within tolerance except IsAlphaNumericUnicode which got 20% faster it seems
```
benchmark baseline contender change %
counters
3 IsAlphaNumericUnicode 639.335 MiB/sec 785.883 MiB/sec 22.922
{'iterations': 29}
0 Utf8Lower 447.866 MiB/sec 467.099 MiB/sec 4.294
{'iterations': 20}
5 Utf8Upper 460.699 MiB/sec 467.486 MiB/sec 1.473
{'iterations': 20}
1 BinaryContainsExact 581.487 MiB/sec 564.348 MiB/sec -2.947
{'iterations': 26}
2 IsAlphaNumericAscii 904.964 MiB/sec 876.430 MiB/sec -3.153
{'iterations': 42}
6 AsciiLower 10.095 GiB/sec 9.711 GiB/sec -3.802
{'iterations': 440}
4 AsciiUpper 9.972 GiB/sec 9.453 GiB/sec -5.206
{'iterations': 443}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
