wesm commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-657174882
+1. Here are the benchmarks with gcc-8 comparing the last commit with
3739e6681 which is right before I started making changes
```
benchmark baseline contender change %
counters
6 IsAlphaNumericUnicode 644.115 MiB/sec 829.133 MiB/sec 28.724
{'iterations': 29}
2 Utf8Lower 453.035 MiB/sec 478.970 MiB/sec 5.725
{'iterations': 20}
4 Utf8Upper 462.962 MiB/sec 488.924 MiB/sec 5.608
{'iterations': 21}
3 AsciiUpper 9.913 GiB/sec 10.098 GiB/sec 1.864
{'iterations': 446}
0 AsciiLower 9.956 GiB/sec 9.951 GiB/sec -0.050
{'iterations': 435}
5 BinaryContainsExact 582.241 MiB/sec 570.008 MiB/sec -2.101
{'iterations': 26}
1 IsAlphaNumericAscii 977.104 MiB/sec 920.929 MiB/sec -5.749
{'iterations': 43}
```
I think +/- 5% is basically noise on these so merging. Thanks
@maartenbreddels!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
