romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r459551825
##########
File path: r/R/array.R
##########
@@ -119,9 +119,9 @@ Array <- R6Class("Array",
},
Slice = function(offset, length = NULL) {
if (is.null(length)) {
- Array$create(Array__Slice1(self, offset))
+ Array$create(Array__Slice1(self, as_index(offset)))
} else {
- Array$create(Array__Slice2(self, offset, length))
+ Array$create(Array__Slice2(self, as_index(offset), length))
Review comment:
Yeah, I'm wondering if this could be handled by a C++ class instead. For
now, I'm just trying to make it all pass. This is only needed if converting to
`int` refuses to deal with `NA` (which is a logical), i.e.
https://github.com/r-lib/cpp11/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
