romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r464531038
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -131,14 +131,14 @@ test_that("Slice() and RangeEquals()", {
expect_true(x$RangeEquals(z, 10, 15, 0))
# Input validation
- expect_error(x$Slice("ten"), class = "Rcpp::not_compatible")
+ expect_error(x$Slice("ten"))
Review comment:
They were a bit over designed in Rcpp, I think a wrapper around
`rlang::abort()` might help though. Some way to have:
- a class to the R condition
- and then some context data, e.g. the `...` from ?abort
I don't think it makes a lot of sense to have various C++ exception classes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
