emkornfield commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r464025600
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java
##########
@@ -403,16 +421,29 @@ public static ArrowRecordBatch
deserializeRecordBatch(RecordBatch recordBatchFB,
nodes.add(new ArrowFieldNode(node.length(), node.nullCount()));
}
List<ArrowBuf> buffers = new ArrayList<>();
+ long curOffset = 0L;
for (int i = 0; i < recordBatchFB.buffersLength(); ++i) {
Buffer bufferFB = recordBatchFB.buffers(i);
ArrowBuf vectorBuffer = body.slice(bufferFB.offset(), bufferFB.length());
+ curOffset = bufferFB.offset() + bufferFB.length();
buffers.add(vectorBuffer);
}
+
+ if (curOffset % 8 != 0) {
+ curOffset += 8 - curOffset % 8;
+ }
+ ArrowBodyCompression bodyCompression = null;
Review comment:
It looks like this is manually parsing the buffer stream? I would have
expected to directly reference A body compression object directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
