emkornfield commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r464025727
##########
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java
##########
@@ -353,6 +361,23 @@ private InputStream asInputStream(BufferAllocator
allocator) {
// the reference count
b.getReferenceManager().retain();
}
+
+ // add compression info, if any
+ if (bodyCompression != null) {
+ ArrowBuf compBuf =
allocator.buffer(ArrowBodyCompression.BODY_COMPRESSION_LENGTH);
+ compBuf.setByte(0, bodyCompression.getCodec());
Review comment:
it looks like this is manually serializing the table, shouldn't this be
delegated to flatbuffers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
