bdunlay commented on a change in pull request #7939:
URL: https://github.com/apache/arrow/pull/7939#discussion_r469065711
##########
File path: cpp/src/arrow/util/checked_cast.h
##########
@@ -32,28 +32,28 @@ inline OutputType checked_cast(InputType&& value) {
static_assert(std::is_class<typename std::remove_pointer<
typename
std::remove_reference<OutputType>::type>::type>::value,
"checked_cast output type must be a class");
-#ifdef NDEBUG
Review comment:
CI failed here because it explicitly undefined NDEBUG on a release
build. I don't think these are public headers, so I could omit the change here
and leave it as it was.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
