pitrou commented on pull request #7939:
URL: https://github.com/apache/arrow/pull/7939#issuecomment-672732537


   I don't know why @kou suggested the flag change. If I look at headers in 
`/usr/include` on Ubuntu 18.04, several of them use `NDEBUG` in places: it 
doesn't seem to be causing any issues in practice.
   
   As for `arrow/util/trie.h`, the method should simply always be defined even 
if not used (though I'm not even sure that matters, since it's an inline 
method...).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to