jorisvandenbossche commented on a change in pull request #7907:
URL: https://github.com/apache/arrow/pull/7907#discussion_r469348756
##########
File path: python/pyarrow/fs.py
##########
@@ -117,6 +116,9 @@ def get_type_name(self):
protocol = protocol[0]
return "fsspec+{0}".format(protocol)
+ def normalize_path(self, path):
+ return path
Review comment:
From a quick looks, it seems that their LocalFileSystem should handle
incoming "windows" (non-normalized) paths (see eg
https://github.com/intake/filesystem_spec/pull/65/files, where a bunch of `path
= make_path_posix(path)` were added to the LocalFileSystem methods). So I think
this should be fine.
Only, do we rely on this method on the C++ side to actually return a
normalized path?
Eg in the C++ dataset discovery code, that might be relying on being able to
split the normalized path on `/` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
