jorisvandenbossche commented on a change in pull request #7907:
URL: https://github.com/apache/arrow/pull/7907#discussion_r469901269
##########
File path: python/pyarrow/fs.py
##########
@@ -117,6 +116,9 @@ def get_type_name(self):
protocol = protocol[0]
return "fsspec+{0}".format(protocol)
+ def normalize_path(self, path):
+ return path
Review comment:
We indeed already do that:
https://github.com/apache/arrow/blob/90d1ab73a132faaaa0a205a8640d78bf1c60005f/python/pyarrow/fs.py#L77-L79
at least in cases where the `_ensure_filesystem` is used to process the user
specified filesystem before passing it to the underlying functions (but which
should in principle be done by all user facing functions).
So the actual fsspec's LocalFileSystem is only used for testing, so I think
this is certainly fine then (since other filesystems should not have this
problem of windows paths)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
