sunchao commented on a change in pull request #1432:
URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826608711
##########
File path: arrow/src/array/array.rs
##########
@@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw(
schema: *const ffi::FFI_ArrowSchema,
) -> Result<ArrayRef> {
let array = ffi::ArrowArray::try_from_raw(array, schema)?;
- let data = ArrayData::try_from(array)?;
+ let data = ArrayData::try_from(&array)?;
+ // Avoid dropping the `Box` pointers and trigger the `release` mechanism.
+ let _ = ffi::ArrowArray::into_raw(array);
Review comment:
You mean after calling `make_array_from_raw` to obtain `ArrayRef`, the
caller is responsible to call `release` on the aliases (i.e., `Arc`) of the
input `array` and `schema`, after it has done using the `ArrayRef`?
BTW what is the `Buffer` you mentioned? I don't see it in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
