pitrou commented on a change in pull request #166:
URL: https://github.com/apache/arrow-cookbook/pull/166#discussion_r829296501



##########
File path: cpp/code/basic_arrow.cc
##########
@@ -63,3 +66,54 @@ arrow::Status ReturnNotOk() {
 TEST(BasicArrow, ReturnNotOkNoMacro) { ASSERT_OK(ReturnNotOkMacro()); }
 
 TEST(BasicArrow, ReturnNotOk) { ASSERT_OK(ReturnNotOk()); }
+
+class TypeCountVisitor : public arrow::TypeVisitor {
+ public:
+  uint64_t nested_count;
+  uint64_t non_nested_count;
+
+  template <typename T>
+  arrow::enable_if_not_nested<T, arrow::Status> Visit(const T&) {

Review comment:
       Because you're not overriding the actual base method, you're defining an 
unrelated template method which happens to have the same name :-)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to