pitrou commented on a change in pull request #166:
URL: https://github.com/apache/arrow-cookbook/pull/166#discussion_r831132145
##########
File path: cpp/code/basic_arrow.cc
##########
@@ -18,6 +18,12 @@
#include <arrow/api.h>
#include <gtest/gtest.h>
+#include <random>
+
+#include "arrow/array.h"
+#include "arrow/type.h"
+#include "arrow/type_traits.h"
+#include "arrow/visit_array_inline.h"
Review comment:
@westonpace Do we have a convention for Arrow C++ includes in the
cookbook? Above `api.h` is being included and this PR is adding other more
fine-grained inclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
