westonpace commented on a change in pull request #12537: URL: https://github.com/apache/arrow/pull/12537#discussion_r829478094
########## File path: cpp/src/arrow/compute/exec/tpch_node.h ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <string> +#include <vector> +#include "arrow/compute/exec/exec_plan.h" +#include "arrow/compute/exec/options.h" +#include "arrow/result.h" +#include "arrow/status.h" +#include "arrow/type.h" +#include "arrow/util/pcg_random.h" + +namespace arrow { +namespace compute { Review comment: I agree we want users to use this but I don't think that means we will need the node in a public namespace. Eventually, we will add function registry and Substrait integrations. At that point we will probably create some kind of "options" object which will be in the public API. At that point the nodes could even be in anonymous namespace, however I think the direct construction is necessary now and will probably still be useful in the future for unit testing. I think `arrow::compute::internal` is reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
