lidavidm commented on a change in pull request #12636:
URL: https://github.com/apache/arrow/pull/12636#discussion_r829400024
##########
File path: format/Flight.proto
##########
@@ -280,9 +281,16 @@ message FlightEndpoint {
Ticket ticket = 1;
/*
- * A list of URIs where this ticket can be redeemed. If the list is
- * empty, the expectation is that the ticket can only be redeemed on the
- * current service where the ticket was generated.
+ * A list of URIs where this ticket can be redeemed.
+ *
+ * If the list is empty, the expectation is that the ticket can only
+ * be redeemed on the current service where the ticket was
+ * generated.
+ *
+ * If the list is not empty, the expectation is that the ticket can
+ * be redeemed at any of the locations, and that the data returned
+ * will be equivalent. In other words, multiple locations provide
+ * redundancy/load balancing.
Review comment:
I think that would be good to clarify, but that doesn't answer the
question of, "if there are locations, can the ticket still be redeemed on the
original server, or must it only be redeemed on one of the given locations"?
##########
File path: format/Flight.proto
##########
@@ -280,9 +281,16 @@ message FlightEndpoint {
Ticket ticket = 1;
/*
- * A list of URIs where this ticket can be redeemed. If the list is
- * empty, the expectation is that the ticket can only be redeemed on the
- * current service where the ticket was generated.
+ * A list of URIs where this ticket can be redeemed.
+ *
+ * If the list is empty, the expectation is that the ticket can only
+ * be redeemed on the current service where the ticket was
+ * generated.
+ *
+ * If the list is not empty, the expectation is that the ticket can
+ * be redeemed at any of the locations, and that the data returned
+ * will be equivalent. In other words, multiple locations provide
+ * redundancy/load balancing.
Review comment:
Thanks for the comments, I've updated this PR with both the `Ticket` and
`locations` clarifications
##########
File path: format/Flight.proto
##########
@@ -259,8 +259,10 @@ message FlightInfo {
FlightDescriptor flight_descriptor = 2;
/*
- * A list of endpoints associated with the flight. To consume the whole
- * flight, all endpoints must be consumed.
+ * A list of endpoints associated with the flight. To consume the
+ * whole flight, all endpoints (and hence all Tickets) must be consumed.
Review comment:
Updated.
Though - that brings up the question of how to represent an ordered dataset.
Is the expectation that (say) if results are sorted, then the endpoints should
also be sorted?
##########
File path: format/Flight.proto
##########
@@ -259,8 +259,10 @@ message FlightInfo {
FlightDescriptor flight_descriptor = 2;
/*
- * A list of endpoints associated with the flight. To consume the whole
- * flight, all endpoints must be consumed.
+ * A list of endpoints associated with the flight. To consume the
+ * whole flight, all endpoints (and hence all Tickets) must be consumed.
+ *
+ * In other words, multiple endpoints provide partitioning.
Review comment:
That's a very good point. I've reworded things here, how does it look
now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
