lidavidm commented on pull request #12609: URL: https://github.com/apache/arrow/pull/12609#issuecomment-1072628829
Looking at it I would guess it's because tracing_internal.h doesn't include all of the necessary OTel headers to fully define shared_ptr and/or Span. I wonder how to best do this though…either we have to start exposing OTel in the headers and hence in our ABI…or we would need to define something like `arrow::tracing::internal::WrapCallback()` that is type-erased and saves/restores the current span (and maybe that affects inlining?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
