lidavidm commented on pull request #12609:
URL: https://github.com/apache/arrow/pull/12609#issuecomment-1075127236


   This gets me a little further, but then you need to deal with returning void 
vs non-void:
   
   ```diff
   --- a/cpp/src/arrow/util/thread_pool.h
   +++ b/cpp/src/arrow/util/thread_pool.h
   @@ -169,7 +169,7 @@ class ARROW_EXPORT Executor {
          opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> 
activeSpan;
        } wrapper{std::forward<Function>(func), 
::arrow::internal::tracing::GetTracer()->GetCurrentSpan()};
        auto task = std::bind(::arrow::detail::ContinueFuture{}, future,
   -                          std::forward<Function>(wrapper), 
std::forward<Args>(args)...);
   +                          wrapper, std::forward<Args>(args)...);
    #else
        auto task = std::bind(::arrow::detail::ContinueFuture{}, future,
                              std::forward<Function>(func), 
std::forward<Args>(args)...);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to