pitrou commented on a change in pull request #12698:
URL: https://github.com/apache/arrow/pull/12698#discussion_r834306523
##########
File path: dev/archery/archery/lang/python.py
##########
@@ -139,10 +143,19 @@ def traverse(self, fn, obj, from_package):
continue
member = getattr(obj, name)
- module = getattr(member, '__module__', None)
- if not (module and module.startswith(from_package)):
+ module = _get_module(member)
+ if module is None or not module.startswith(from_package):
continue
-
+ # Is it a Cython-generated method? If so, try to detect
+ # whether it has a implicitly-generated docstring due to
+ # the Cython `embedsignature` directive; and if so, skip
Review comment:
Yes, exactly. I could improve the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
