pitrou commented on a change in pull request #12698:
URL: https://github.com/apache/arrow/pull/12698#discussion_r836541028
##########
File path: python/pyarrow/io.pxi
##########
@@ -1257,6 +1283,10 @@ cdef class BufferReader(NativeFile):
cdef:
Buffer buffer
+ # XXX Needed to make numpydoc happy
+ def __init__(self, obj):
Review comment:
The problem is that numpydoc tries to match the parameters documented in
the `BufferReader` docstring with its `__init__` signature. To be honest, I'm
not sure why some classes prefer to define `__cinit__` rather than `__init__`,
there doesn't seem to be a consistent convention across the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
