jorgecarleitao commented on a change in pull request #7971:
URL: https://github.com/apache/arrow/pull/7971#discussion_r471706745
##########
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##########
@@ -20,25 +20,33 @@
use std::fmt;
use arrow::array::ArrayRef;
-use arrow::datatypes::{DataType, Field, Schema};
+use arrow::datatypes::{DataType, Schema};
use crate::error::Result;
use crate::execution::physical_plan::PhysicalExpr;
+use super::{Accumulator, AggregateExpr, Aggregator};
use arrow::record_batch::RecordBatch;
use fmt::{Debug, Formatter};
-use std::sync::Arc;
+use std::{cell::RefCell, rc::Rc, sync::Arc};
/// Scalar UDF
pub type ScalarUdf = Arc<dyn Fn(&[ArrayRef]) -> Result<ArrayRef> + Send +
Sync>;
+/// Function to construct the return type of a function given its arguments.
+pub type ReturnType =
Review comment:
This can't be an HashMap because the number of arguments is unknown and
thus we don't know the key length a priori :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
